malliaridis commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1981863388
##########
solr/bin/solr:
##########
@@ -612,22 +612,11 @@ if [[ "$SCRIPT_CMD" == "auth" ]]; then
fi
fi
- if [ -z "${AUTH_PORT:-}" ]; then
- for ID in $(ps auxww | grep java | grep start\.jar | awk '{print $2}' |
sort -r)
- do
- port=$(jetty_port "$ID")
- if [ "$port" != "" ]; then
- AUTH_PORT=$port
- break
- fi
- done
- fi
-
- run_tool auth $@ --solr-url
"$SOLR_URL_SCHEME://$SOLR_TOOL_HOST:${AUTH_PORT:-8983}" --auth-conf-dir
"$SOLR_HOME" "--solr-include-file" "$SOLR_INCLUDE"
Review Comment:
This eliminates the `AUTH_PORT` and `SOLR_TOOL_HOST` environment variables,
right? I believe it is fine, as the behavior is checking the jetty port and
falls back to the default Solr port, so no need to distinguish it in the
scripts.
Still, this is a breaking change.
EDIT: I've noticed this eliminates the use of these only in the scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
