epugh commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1987200962
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -75,8 +75,10 @@ public class AuthTool extends ToolBase {
.longOpt("solr-include-file")
.hasArg()
.argName("FILE")
+ .required()
Review Comment:
At least right now, we have logic that if this file does NOT exist or is not
writable, then the AuthTool quits with a warning. So I think making it
required is the right thing. Having said that, longer term maybe something to
think about? Becasue it makes it implicitly assumed that the bin/solr auth
command runs on your Solr server!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
