abumarjikar commented on code in PR #3272:
URL: https://github.com/apache/solr/pull/3272#discussion_r1999683086
##########
solr/core/src/java/org/apache/solr/handler/configsets/CloneConfigSet.java:
##########
@@ -64,8 +64,8 @@ public SolrJerseyResponse
cloneExistingConfigSet(CloneConfigsetRequestBody reque
}
if (!DISABLE_CREATE_AUTH_CHECKS
- && !isTrusted(solrQueryRequest.getUserPrincipal(),
coreContainer.getAuthenticationPlugin())
- && configSetService.isConfigSetTrusted(requestBody.baseConfigSet)) {
+ && !isTrusted(
Review Comment:
not sure if we still need this, i kept it because this check on the not null
on auth plugin and user principal.
##########
solr/core/src/java/org/apache/solr/handler/configsets/ConfigSetAPIBase.java:
##########
@@ -134,24 +134,9 @@ protected void createBaseNode(
throws IOException {
if (overwritesExisting) {
if (!requestIsTrusted) {
- ensureOverwritingUntrustedConfigSet(configName);
+ throw new SolrException(
Review Comment:
The trusted configs was always true and after considering that if the
request is not trusted then we should directly throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
