dsmiley commented on code in PR #3272:
URL: https://github.com/apache/solr/pull/3272#discussion_r2006296762
##########
solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:
##########
@@ -216,13 +215,6 @@ void setScriptEngineCustomizer(ScriptEngineCustomizer
scriptEngineCustomizer) {
@Override
public void inform(SolrCore core) {
- if (!core.getCoreDescriptor().isConfigSetTrusted()) {
Review Comment:
I'd rather not see such a log -- It's up to our documentation to convey
risks of certain features. Let's not scare/shame users for what may be a
reasonable choice on their part. No judgement from me.
Furthermore, the _additional_ risk here is highly dubious -- it's perhaps no
more than a Java class file in the configSet that I reference in solrconfig.xml
(really any plugin). We don't log warnings to scare people away from using
plugins that Solr doesn't ship with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
