dsmiley commented on code in PR #3314:
URL: https://github.com/apache/solr/pull/3314#discussion_r2034228946
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteShardCmd.java:
##########
@@ -238,4 +239,33 @@ private List<ZkNodeProps> getReplicasForSlice(String
collectionName, Slice slice
}
return sourceReplicas;
}
+
+ /**
+ * Best effort to delete Zookeeper nodes that stored other details than the
shard itself in
+ * cluster state. If we fail for any reason, we just log and the shard is
still deleted.
+ */
+ private void cleanupZooKeeperShardMetadata(String collection, String sliceId)
Review Comment:
This approach looks for very specific things, and thus we need to maintain
it and may miss things. Don't we want to delete everything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
