psalagnac commented on code in PR #3314:
URL: https://github.com/apache/solr/pull/3314#discussion_r2035840059
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteShardCmd.java:
##########
@@ -238,4 +239,33 @@ private List<ZkNodeProps> getReplicasForSlice(String
collectionName, Slice slice
}
return sourceReplicas;
}
+
+ /**
+ * Best effort to delete Zookeeper nodes that stored other details than the
shard itself in
+ * cluster state. If we fail for any reason, we just log and the shard is
still deleted.
+ */
+ private void cleanupZooKeeperShardMetadata(String collection, String sliceId)
Review Comment:
Not sure what you mean by _everything_.
Unfortunately, we don't have a per shard root in Zookeeper. I wish we had,
it should simpler to remove all info specific to a shard, but the transition to
a different data layout will be ever complex.
The naive approach is to remove an hardcoded list of ZK node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
