dsmiley commented on code in PR #3340:
URL: https://github.com/apache/solr/pull/3340#discussion_r2075937889
##########
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##########
@@ -547,6 +547,12 @@ private void addField(
String disp = (key == null) ? field : key;
augmenters.addTransformer(new MatchScoreAugmenter(disp));
scoreDependentFields.put(disp, disp.equals(MATCH_SCORE) ? "" :
MATCH_SCORE);
+ } else if (key != null && isPseudoField) {
+ // SOLR-15030: a pseudo-field based on the function query may need
scores,
+ // so we consider all pseudo-fields as potentially requiring scores.
+ // At the same time, we don't set _wantScore = true because the field
+ // list must explicitly include 'score' field to enable scores
Review Comment:
nor does a `ValueSource` have `needsScores`. But `DoubleValuesSource`
(Lucene's modern replacement over legacy VS) _does_.
Addressing that is perhaps for another issue/PR. Progress not perfection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
