alessandrobenedetti commented on code in PR #3354:
URL: https://github.com/apache/solr/pull/3354#discussion_r2096070495
##########
solr/modules/ltr/src/test/org/apache/solr/ltr/TestSelectiveWeightCreation.java:
##########
@@ -142,7 +142,10 @@ public void testScoringQueryWeightCreation() throws
IOException, ModelException
assertEquals("11",
searcher.storedFields().document(hits.scoreDocs[1].doc).get("id"));
List<Feature> features = makeFeatures(new int[] {0, 1, 2});
+ List<Feature> expectedNotDefaultFeatures = makeFeatures(new int[] {1, 2});
final List<Feature> allFeatures = makeFeatures(new int[] {0, 1, 2, 3, 4,
5, 6, 7, 8, 9});
+ List<Feature> expectedNotDefaultAllFeatures =
Review Comment:
same and it applies in general to the usage of 'not', when associated to an
adjective, you should use:
non Default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
