alessandrobenedetti commented on code in PR #3354:
URL: https://github.com/apache/solr/pull/3354#discussion_r2096079563
##########
solr/modules/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java:
##########
@@ -250,6 +250,31 @@ public void
testIfADocumentDoesntHaveAFieldDefaultValueIsReturned() throws Excep
assertJQ("/query" + query.toQueryString(), "/response/numFound/==1");
assertJQ("/query" + query.toQueryString(), "/response/docs/[0]/id=='42'");
+ final String docs0fv_dense_csv =
Review Comment:
Are all these tests just refactoring? It's hard to review, and if there's no
actual test change, I would strongly encourage leaving them as they were.
When bug-fixing, the less we touch the tests, the better, so it's clear
nothing has been broken by the bugfix,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
