epugh commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2113847898
##########
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##########
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOException {
commandsExecuted.add(cmd);
String exe = cmd.getExecutable();
- if (exe.endsWith("solr")) {
+ if (exe.endsWith("solr") || exe.endsWith("solr.cmd")) {
Review Comment:
somethign I am confused by.... How would the exe ever NOT be either solr
or solr.cmd??? Is there a way this code can be run that doesn't include one
of those? I am just wondering if we need this if statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
