epugh commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2113850972
##########
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##########
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOException {
commandsExecuted.add(cmd);
String exe = cmd.getExecutable();
- if (exe.endsWith("solr")) {
+ if (exe.endsWith("solr") || exe.endsWith("solr.cmd")) {
Review Comment:
i looked at the class... and it's super specific to testing Solr CLI, so I
can't imagine a world where anything BUT a solr or solr.cmd is used??? In
fact, I think an assert would be more apprporiate, to fail the test if you used
this class with anything but solr or solr.cmd?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
