dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2125527519
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -862,7 +862,6 @@ private void doCompatCheck(BiConsumer<String, Object>
consumer) {
new Http2SolrClient.Builder()
.withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
.withIdleTimeout(30000, TimeUnit.MILLISECONDS)
- .withConnectionTimeout(15000, TimeUnit.MILLISECONDS)
Review Comment:
Not supported anymore if we use an existing HttpClient. No big deal.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java:
##########
@@ -57,8 +57,6 @@ public abstract class HttpSolrClientBase extends SolrClient {
/** The URL of the Solr server. */
protected final String serverBaseUrl;
- protected final long idleTimeoutMillis;
Review Comment:
and isn't supported by the Jdk HttpClient
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -287,7 +284,6 @@ public IndexFetcher(
String compress = (String) initArgs.get(COMPRESSION);
useInternalCompression = ReplicationHandler.INTERNAL.equals(compress);
useExternalCompression = ReplicationHandler.EXTERNAL.equals(compress);
- connTimeout = getParameter(initArgs,
HttpClientUtil.PROP_CONNECTION_TIMEOUT, 30000, null);
Review Comment:
Not supported anymore if we use an existing HttpClient. No big deal.
Here this setting comes from ReplicationHandler config in solrconfig.xml but
I don't think anyone specifies this (I searched for it and didn't see in all of
Solr configs/tests).
##########
solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java:
##########
@@ -360,7 +360,6 @@ private void requestRecovery(
try (SolrClient client =
new Http2SolrClient.Builder(baseUrl)
.withHttpClient(solrClient)
- .withConnectionTimeout(30000, TimeUnit.MILLISECONDS)
Review Comment:
Not supported anymore if we use an existing HttpClient. No big deal.
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -205,19 +205,13 @@ private static Http2SolrClient.Builder
newHttp2SolrClientBuilder(
.withDefaultCollection(URLUtil.extractCoreFromCoreUrl(url));
if (http2SolrClient != null) {
builder.withHttpClient(http2SolrClient);
+ // cannot set connection timeout
Review Comment:
Okay? I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
