dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2130657407
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -205,19 +205,13 @@ private static Http2SolrClient.Builder
newHttp2SolrClientBuilder(
.withDefaultCollection(URLUtil.extractCoreFromCoreUrl(url));
if (http2SolrClient != null) {
builder.withHttpClient(http2SolrClient);
+ // cannot set connection timeout
Review Comment:
I dug into this... the timeouts came from
https://issues.apache.org/jira/browse/SOLR-14672 which is more about making
them inheritable instead of hard-coded. We have that already -- they are
inherited from the passed in client, which in turn has values that are
configurable via HttpSolrClientProvider via UpdateShardHandlerConfig via
solr.xml.
I think we're fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
