dsmiley commented on code in PR #3400:
URL: https://github.com/apache/solr/pull/3400#discussion_r2159697182
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -132,8 +132,9 @@ protected Http2SolrClient(String serverBaseUrl, Builder
builder) {
if (builder.followRedirects != null
|| builder.connectionTimeoutMillis != null
|| builder.maxConnectionsPerHost != null
- || builder.useHttp1_1
- != builder.httpClient.getTransport() instanceof
HttpClientTransportOverHTTP
+ || (builder.providedUseHttp1_1 != null
+ && builder.providedUseHttp1_1
+ != builder.httpClient.getTransport() instanceof
HttpClientTransportOverHTTP)
Review Comment:
I think we now can *and should* drop this part. Just keep this looking
_just_ like the other settings with null checks; very visually obviously
consistent instead of some quirk to ponder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
