HoustonPutman commented on code in PR #3400:
URL: https://github.com/apache/solr/pull/3400#discussion_r2162063251
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##########
@@ -38,7 +38,8 @@ public abstract class HttpSolrClientBuilderBase<
protected Set<String> urlParamNames;
protected Integer maxConnectionsPerHost;
protected ExecutorService executor;
- protected boolean useHttp1_1 = Boolean.getBoolean("solr.http1");
+ protected final boolean defaultUseHttp1_1 = Boolean.getBoolean("solr.http1");
+ protected Boolean providedUseHttp1_1;
Review Comment:
I chose provided for this one, so that people in the future maybe think
twice before using it instead of the `shouldUseHttp1_1()` method to check
whether or not to use http1. Not a huge concern, and I can change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
