dsmiley commented on code in PR #3385:
URL: https://github.com/apache/solr/pull/3385#discussion_r2162356233
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -126,16 +131,41 @@ public DocValuesFormat getDocValuesFormatForField(String
field) {
public KnnVectorsFormat getKnnVectorsFormatForField(String field) {
final SchemaField schemaField =
core.getLatestSchema().getFieldOrNull(field);
FieldType fieldType = (schemaField == null ? null :
schemaField.getType());
- if (fieldType instanceof DenseVectorField vectorType) {
+ KnnVectorsFormat delegate;
Review Comment:
Much better. Did you consider init() also creating the codec to thus avoid
the need corresponding fields, getters, setters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
