liangkaiwen commented on code in PR #3385:
URL: https://github.com/apache/solr/pull/3385#discussion_r2164268484
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -126,16 +131,41 @@ public DocValuesFormat getDocValuesFormatForField(String
field) {
public KnnVectorsFormat getKnnVectorsFormatForField(String field) {
final SchemaField schemaField =
core.getLatestSchema().getFieldOrNull(field);
FieldType fieldType = (schemaField == null ? null :
schemaField.getType());
- if (fieldType instanceof DenseVectorField vectorType) {
+ KnnVectorsFormat delegate;
Review Comment:
That's probably true. However it does look like the getters are used in the
DenseVectorField tests as KnnVectorsFormat doesn't expose the internal setting
values. Personally I think it's ok to leave patterned as-is and having getters
affords some level of flexibility and transparency.
But I can make this change if you feel strongly about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
