[ 
https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985692#comment-17985692
 ] 

ASF subversion and git services commented on SOLR-17776:
--------------------------------------------------------

Commit 5719866a0b5ab6bf881f30010fb01b936e6d3a19 in solr's branch 
refs/heads/main from Houston Putman
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=5719866a0b5 ]

SOLR-17776: Fix over-checking of http1 flag in Http2SolrClient (#3400)



> Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
> --------------------------------------------------------------------
>
>                 Key: SOLR-17776
>                 URL: https://issues.apache.org/jira/browse/SOLR-17776
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 9.9
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> See the linked dev list thread.  Summary:
> If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in 
> 9.8, shifted from deprecated Apache HttpClient based clients): settings 
> affecting HttpClient construction cannot be customized; an 
> IllegalStateException will now be thrown if you try.  The connection timeout 
> cannot be customized, but idle & request timeouts can be.  Callers (various 
> places in Solr) should no longer customize the connection timeout.  
> Additionally, there's a bug wherein withHttpClient usage meant that the idle 
> & request timeouts couldn't be increased.
> The HttpJdkSolrClient wasn't setting the connection timeout as per the 
> builder configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to