[
https://issues.apache.org/jira/browse/SOLR-17628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003617#comment-18003617
]
Matthew Biscocho commented on SOLR-17628:
-----------------------------------------
Partially I guess yes for timers at a query or aggregation perspective. If they
built a dashboard from a timer metric then yes the name changed and could break
it. From scraping shouldn't be an issue for users picking it up as plug and
play.
The solr_metrics_core_average_request_time shouldn't have existed. Users can
and should get this value in the new change by calculating it from querying the
new solr_metrics_core_request_time_ms_sum and
solr_metrics_core_request_time_ms_count metrics which is how it should have
been as the client defines the window of the average, not Solr.
I can keep it backwards compat for 9.9 or 9.10 then by keeping
solr_metrics_core_average_request_time in the branch and marking it deprecated
somehow, but for solr_metrics_core_requests_time that means we may have
duplicates of the values as it should be the equivalent of
`solr_metrics_core_request_time_ms_sum` in this change.
> Add query quantiles metrics to prometheus endpoint
> ---------------------------------------------------
>
> Key: SOLR-17628
> URL: https://issues.apache.org/jira/browse/SOLR-17628
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Matthew Biscocho
> Priority: Major
> Labels: pull-request-available
> Fix For: 9.9
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When exposing prometheus metrics with SOLR-10654 exporting metrics was mostly
> straight forward except for query metric quantiles. Things such as average
> request times exists with the current prometheus internal formatters. But
> Dropwizard gauges can have more complex types in their data structures and
> quantiles fell in that bucket so at the time, exporting these quantiles
> wasn't straight forward. I think these metrics would be very beneficial to
> finally add in and export.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
