dsmiley commented on code in PR #3417:
URL: https://github.com/apache/solr/pull/3417#discussion_r2196261032
##########
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java:
##########
@@ -262,27 +262,29 @@ public void initializeMetrics(
baseCommandsMetric,
baseAttributes.get().put(OPERATION_ATTR,
"deletes_by_query").build());
+ var baseCommitMetric =
Review Comment:
Why is this a "base"; why do you refer to it in the metrics for commands &
merges below other than "commits"?
##########
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java:
##########
@@ -262,27 +262,29 @@ public void initializeMetrics(
baseCommandsMetric,
baseAttributes.get().put(OPERATION_ATTR,
"deletes_by_query").build());
+ var baseCommitMetric =
+ solrMetricsContext.longCounter(
+ "solr_core_update_commit_operations", "Total number of commit
operations");
+
commitCommands =
- new AttributedLongUpDownCounter(
- baseCommandsMetric, baseAttributes.get().put(OPERATION_ATTR,
"commits").build());
+ new AttributedLongCounter(
+ baseCommitMetric, baseAttributes.get().put(OPERATION_ATTR,
"commits").build());
optimizeCommands =
- new AttributedLongUpDownCounter(
- baseCommandsMetric, baseAttributes.get().put(OPERATION_ATTR,
"optimize").build());
+ new AttributedLongCounter(
+ baseCommitMetric, baseAttributes.get().put(OPERATION_ATTR,
"optimize").build());
mergeIndexesCommands =
- new AttributedLongUpDownCounter(
- baseCommandsMetric, baseAttributes.get().put(OPERATION_ATTR,
"merges").build());
+ new AttributedLongCounter(
+ baseCommitMetric, baseAttributes.get().put(OPERATION_ATTR,
"merges").build());
Review Comment:
oh this is a command and not merges generally. "mergeIndexes"? At least
it's scoped by the OPERATION_ATTR so in-context, it ought to be clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
