mlbiscoc commented on code in PR #3417:
URL: https://github.com/apache/solr/pull/3417#discussion_r2219394270
##########
solr/core/src/test/org/apache/solr/cloud/TestTlogReplica.java:
##########
@@ -576,43 +576,31 @@ public void testOnlyLeaderIndexes() throws Exception {
{
SolrCore core = getSolrCore(true).getFirst();
- var reader =
- core.getSolrMetricsContext()
- .getMetricManager()
- .getPrometheusMetricReader(
-
getSolrCore(true).getFirst().getCoreMetricManager().getRegistryName());
var actual =
- (GaugeSnapshot.GaugeDataPointSnapshot)
- SolrMetricTestUtils.getDataPointSnapshot(
- reader,
- "solr_metrics_core_update_pending_operations",
- SolrMetricTestUtils.getCloudLabelsBase(core)
- .get()
- .label("category", "UPDATE")
- .label("operation", "docs_pending")
- .build());
+ SolrMetricTestUtils.getGaugeDatapoint(
+ core,
+ "solr_core_update_docs_pending_commit",
+ Labels.builder()
+ .label("category", "UPDATE")
+ .label("operation", "docs_pending")
Review Comment:
I was doing a `hasSameValues` instead of `equals` which is why it was still
passing. Should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
