mlbiscoc commented on code in PR #3413:
URL: https://github.com/apache/solr/pull/3413#discussion_r2207725353
##########
solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java:
##########
@@ -723,10 +734,15 @@ public SdkMeterProvider meterProvider(String
providerName) {
providerName,
key -> {
var reader = new PrometheusMetricReader(true, null);
- // NOCOMMIT: We need to add a Periodic Metric Reader here if we
want to push with OTLP
- // with an exporter
- var provider =
SdkMeterProvider.builder().registerMetricReader(reader).build();
- return new MeterProviderAndReaders(provider, reader);
+ var builder =
+ SdkMeterProvider.builder()
+ .registerMetricReader(reader)
+ .registerMetricReader(
+ PeriodicMetricReader.builder(metricExporter)
+ .setInterval(OTLP_EXPORTER_INTERVAL,
TimeUnit.MILLISECONDS)
+ .build());
+ SdkMeterProviderUtil.setExemplarFilter(builder,
ExemplarFilter.traceBased());
Review Comment:
Removed exemplar support here to not confuse the scope changes. Go to [this
PR](https://github.com/apache/solr/pull/3427) instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
