dsmiley commented on code in PR #3430: URL: https://github.com/apache/solr/pull/3430#discussion_r2220704438
########## solr/core/src/test/org/apache/solr/metrics/SolrMetricsIntegrationTest.java: ########## @@ -49,6 +50,10 @@ import org.junit.Before; import org.junit.Test; +// NOCOMMIT: Test fails because of the @After assert on index path. Was going to migrate to just +// check the registry for the core is deleted but this test does a rename operation which otel has +// not addressed yet. Need to migrate the rename operation to otel first. [email protected](bugUrl = "https://issues.apache.org/jira/browse/SOLR-17458";) public class SolrMetricsIntegrationTest extends SolrTestCaseJ4 { Review Comment: Seems like a fair proposal to me: Continue to support those standalone mode features but with documented issues of metrics resetting. As long as that's not particularly hard to do, any way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
