dsmiley commented on code in PR #3430:
URL: https://github.com/apache/solr/pull/3430#discussion_r2220731132
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -1305,92 +1321,129 @@ private SolrCoreMetricManager
initCoreMetricManager(SolrConfig config) {
return coreMetricManager;
}
- // TODO SOLR-17458: Migrate to Otel
@Override
public void initializeMetrics(
SolrMetricsContext parentContext, Attributes attributes, String scope) {
- newSearcherCounter = parentContext.counter("new",
Category.SEARCHER.toString());
- newSearcherTimer = parentContext.timer("time",
Category.SEARCHER.toString(), "new");
- newSearcherWarmupTimer = parentContext.timer("warmup",
Category.SEARCHER.toString(), "new");
+
+ var searcherAttributesBuilder =
Review Comment:
We wouldn't re-use a builder; we'd create new builder instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
