dsmiley commented on code in PR #3289: URL: https://github.com/apache/solr/pull/3289#discussion_r2240982786
########## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java: ########## Review Comment: The use of `Path.of` in `uploadToZK` file is an absolute tragedy. There are lots of nice utility methods in this class that take a Path argument (yay), then convert to a String (boo), then pass to Path.of (nausea), thus assuming it's a file system path. So much for uploading a configSet from a ZIP/JAR. Not introduced by you of course, but I thought you might care. @AndreyBozhko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
