aruggero commented on code in PR #3433:
URL: https://github.com/apache/solr/pull/3433#discussion_r2244800527


##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -716,6 +727,11 @@ public <K, V> boolean regenerateItem(
           });
     }
 
+    if (solrConfig.featureVectorCacheConfig != null
+        && solrConfig.featureVectorCacheConfig.getRegenerator() == null) {
+      solrConfig.featureVectorCacheConfig.setRegenerator(new 
NoOpRegenerator());

Review Comment:
   The docId is the Lucene doc ID. Let's keep this without a regenerator by 
now. For feature enhancement, it could be considered using the unique Solr key 
as the key for the feature vector cache instead of the Lucene ID.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to