aruggero commented on code in PR #3433:
URL: https://github.com/apache/solr/pull/3433#discussion_r2259382812
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -423,16 +420,13 @@ private void implTransform(SolrDocument doc, int docid,
DocIterationInfo docInfo
}
}
if (!(rerankingQuery instanceof OriginalRankingLTRScoringQuery) ||
hasExplicitFeatureStore) {
- Object featureVector = featureLogger.getFeatureVector(docid,
rerankingQuery, searcher);
- if (featureVector == null) { // FV for this document was not in the
cache
- featureVector =
- featureLogger.makeFeatureVector(
- LTRRescorer.extractFeaturesInfo(
- rerankingModelWeight,
- docid,
- (!docsWereReranked && docsHaveScores) ? docInfo.score()
: null,
- leafContexts));
- }
+ String featureVector =
+ featureLogger.printFeatureVector(
+ LTRRescorer.extractFeaturesInfo(
Review Comment:
Moved the method extractFeaturesInfo() inside
LTRFeatureLoggerTransformerFactory since it is related to logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
