dsmiley commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r2250403098
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -215,6 +215,11 @@ public static Object fromJavabin(byte[] bytes) throws
IOException {
return jbc.unmarshal(bytes);
}
}
+ public static Object fromJavabin(InputStream is) throws IOException {
Review Comment:
I see you are just adding another overload... but Utils classes can be a
disappointed dumping ground of orphans that ought to find better homes. In
this case, the right home is obviously JavaBinCodec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
