epugh commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r2250959573
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -215,6 +215,11 @@ public static Object fromJavabin(byte[] bytes) throws
IOException {
return jbc.unmarshal(bytes);
}
}
+ public static Object fromJavabin(InputStream is) throws IOException {
Review Comment:
worth creating a JIRA to remind us about refactoring? I wish there was a
nice way for us to track refactoring opportunities... I often discover a
refactoring opportunity that is adjacent to what I am working on, and then
either forget, or if I do it immediately, then it blows up the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
