wildtusker commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3172344898
In some files changes have been made and test cases pass.In some files handleselect is mentioned but clarity is not there what needs to be removed. [6:34](https://apachesolr.slack.com/archives/D08S18704UT/p1754744681250969) List of files : TestConfigOverlay Done TestRemoteStreaming Done EditableSolrConfigAttributes Done Query.js Done schema-designer.js Done SolrTable.java ( Handle Select tuple is there in the file .The instance gets created when metricslist and buckets is empty. ) requestDispathcher.adoc (Documentation for handleselect needs to be removed ) (edited) if (metricPairs.isEmpty() && buckets.isEmpty()) { tupleStream = handleSelect(zk, collection, q, fields, orders, limit, offset); } > Please search for "handleSelect" more thoroughly. Your changes here are good but incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
