epugh commented on code in PR #3312:
URL: https://github.com/apache/solr/pull/3312#discussion_r2290538688
##########
solr/bin/solr:
##########
@@ -1016,10 +1016,6 @@ elif [[ $SOLR_HOME != /* ]]; then
fi
fi
-# Set the default configset dir to be bootstrapped as _default
-: "${SOLR_DEFAULT_CONFDIR:="$SOLR_SERVER_DIR/solr/configsets/_default/conf"}"
Review Comment:
Turns out that this exact variable declaration is ALSO defined in Java code
via ConfigSetService.getDefaultConfigDirPath.
I didn't go exhaustively thorugh all the places we might try to get a
default configset dir, relying on the tests... I have seen other places where
we declare stuff in the solr/bin files, but then redeclare them in Java code,
so I wasn't totally surprised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
