epugh commented on code in PR #3312: URL: https://github.com/apache/solr/pull/3312#discussion_r2288008085
########## solr/solrj/src/resources/EnvToSyspropMappings.properties: ########## @@ -5,29 +5,21 @@ # This way, env SOLR_FOO_BAR will also match property 'solr.foo.bar' without a mapping in this file # TODO: Deprecate non-standard sysprops and standardize on solr.foo.bar in Solr 10 AWS_PROFILE=aws.profile -DEFAULT_CONFDIR=solr.default.confdir Review Comment: I didn't see a proposed name in the cwiki page for this, it's just listed as `solr.default.confdir`... What do you think about `solr.configset.default.confdir`? Or maybe even `solr.configset.default` with a name, and that figures out the specific location of the confdir under the covers, but not something a user would change? The key bit is what configset you are using, with the default one being `_default`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
