puneeetsharma commented on code in PR #3496:
URL: https://github.com/apache/solr/pull/3496#discussion_r2294785104
##########
solr/core/src/java/org/apache/solr/spelling/SpellCheckCollator.java:
##########
@@ -96,7 +96,7 @@ public List<SpellCheckCollation> collate(
while (tryNo < maxTries && collNo < maxCollations &&
possibilityIter.hasNext()) {
if (queryLimits.maybeExitWithPartialResults("SpellCheck collator")) {
- return List.of();
+ return new ArrayList<>();
Review Comment:
Yes seems good. I’ve added these changes. Returning collations will provide
partial spell-check results when the query limit is exceeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
