malliaridis commented on code in PR #3623:
URL: https://github.com/apache/solr/pull/3623#discussion_r2328597071
##########
solr/webapp/web/js/angular/controllers/plugins.js:
##########
Review Comment:
You may remove the following function variables in this file (usages
removed):
- `getPluginTypes`
- `getPlugins`
- `parseDelta`
##########
solr/webapp/web/js/angular/controllers/plugins.js:
##########
@@ -15,10 +15,8 @@
limitations under the License.
*/
-//NOCOMMIT: This plugin seems tied to the Admin UIs plugin management but is
tied to dropwizard metrics failing some tests.
-// This needs to change how it gets these metrics or we need to make a shim to
the /admin/plugins handler for this to support it
solrAdminApp.controller('PluginsController',
- function($scope, $rootScope, $routeParams, $location, Mbeans, Constants) {
+ function($scope, $rootScope, $routeParams, $location, Mbeans, Metrics,
Constants) {
Review Comment:
You may remove Mbeans reference if no longer used. And the factory in
`services.js` as well.
##########
solr/webapp/web/js/angular/controllers/plugins.js:
##########
@@ -66,23 +70,156 @@ solrAdminApp.controller('PluginsController',
$scope.startRecording = function() {
$scope.isRecording = true;
- Mbeans.reference({core: $routeParams.core}, function(data) {
- $scope.reference = data.reference;
- console.log($scope.reference);
- })
+ $scope.refresh();
}
$scope.stopRecording = function() {
$scope.isRecording = false;
- console.log($scope.reference);
- Mbeans.delta({core: $routeParams.core}, $scope.reference,
function(data) {
- parseDelta($scope.types, data);
- });
+ $scope.refresh();
Review Comment:
Not sure what this recording behavior is used for, but judging by the
previous functions called, I believe it was displaying only metric differences
between two timestamps? Does calling the refresh function in both start and
stop actions here make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
