mlbiscoc commented on code in PR #3623:
URL: https://github.com/apache/solr/pull/3623#discussion_r2333943465
##########
solr/webapp/web/js/angular/controllers/plugins.js:
##########
@@ -66,23 +70,156 @@ solrAdminApp.controller('PluginsController',
$scope.startRecording = function() {
$scope.isRecording = true;
- Mbeans.reference({core: $routeParams.core}, function(data) {
- $scope.reference = data.reference;
- console.log($scope.reference);
- })
+ $scope.refresh();
}
$scope.stopRecording = function() {
$scope.isRecording = false;
- console.log($scope.reference);
- Mbeans.delta({core: $routeParams.core}, $scope.reference,
function(data) {
- parseDelta($scope.types, data);
- });
+ $scope.refresh();
Review Comment:
Correct, its supposed to store the differences between timestamps and it had
something to do with the mbean handler I removed. I migrated it to just
refresh. IMO I don't think Solr should do this difference calculation. I think
Solr generating telemetry and showing it's current/last seen state is enough.
If someone really cared about difference, collect the metrics in your
timeseries backend and aggregate it in a way that is actually useful. Also the
difference could be so large it might not even be useful to try and parse
through the difference. Unless someone feels strongly about it, I just removed
it and again in the new UI we should talk about better ways of displaying
metrics.
##########
solr/webapp/web/js/angular/controllers/plugins.js:
##########
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
