dsmiley commented on code in PR #3625:
URL: https://github.com/apache/solr/pull/3625#discussion_r2328704463
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -255,10 +255,11 @@ public String toString() {
private final Map<String, String> replicasInLeaderInitiatedRecovery = new
HashMap<>();
// This is an expert and unsupported development mode that does not create
Review Comment:
IMO we should drop this entirely. I've never heard of it and doesn't really
sound useful TBH. Why run Solr that only runs ZK (that is confusing BTW!) when
one could run ZK via Docker? Docker makes running anything easy in a developer
workstation scenario, which is what this feature here is for.
CC @markrmiller
##########
solr/bin/solr.in.cmd:
##########
@@ -127,7 +127,7 @@ REM environments where security is not a concern, 0.0.0.0
can be used to allow
REM Solr to accept connections on all network interfaces.
REM set SOLR_JETTY_HOST=127.0.0.1
REM Sets the network interface the Embedded ZK binds to.
-REM set SOLR_ZK_EMBEDDED_HOST=127.0.0.1
+REM set SOLR_ZOOKEEPER_SERVER_EMBEDDED_HOST=127.0.0.1
Review Comment:
why put the word "embedded" in there? "server" implies embedded; it refers
to the ZK server that Solr is running itself, embedded.
I could see swapping SERVER for EMBEDDED though... it would be clearer.
##########
solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties:
##########
@@ -55,3 +57,8 @@ solr.ui.enabled=!solr.admin.ui.disabled
solr.ui.experimental.enabled=!solr.admin.ui.experimental.disabled
solr.zookeeper.chroot.create=create.zk.chroot
+solr.zookeeper.server.confdir=zk.server.conf.dir
+solr.zookeeper.server.datadir=zk.server.data.dir
+solr.zookeeper.server.enabled=zk.run
+solr.zookeeper.server.embedded.host=solr.zk.embedded.host
Review Comment:
ah; only this one did you put "embedded". again; don't need both "server"
and "embedded"; pick one consistently for the set of running and embedded ZK
server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
