dsmiley commented on code in PR #3625: URL: https://github.com/apache/solr/pull/3625#discussion_r2328833736
########## solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties: ########## @@ -55,3 +57,8 @@ solr.ui.enabled=!solr.admin.ui.disabled solr.ui.experimental.enabled=!solr.admin.ui.experimental.disabled solr.zookeeper.chroot.create=create.zk.chroot +solr.zookeeper.server.confdir=zk.server.conf.dir +solr.zookeeper.server.datadir=zk.server.data.dir +solr.zookeeper.server.enabled=zk.run +solr.zookeeper.server.embedded.host=solr.zk.embedded.host Review Comment: That is the same thing. There is no distinction. Solr only runs the server embedded; Solr doesn't run ZK separately. A user probably will but not Solr. These "server" props listed (like confdir) only applies to embedding ZK. In theory we might decide to fork a process to run another JVM for ZK... that would then not be "embedded". I could go either way on standardizing on "server" or "embedded" but I definitely propose we pick one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
