dsmiley commented on code in PR #3518:
URL: https://github.com/apache/solr/pull/3518#discussion_r2330752618
##########
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##########
@@ -217,19 +219,12 @@ private NamedList<Object> getDetails(SolrClient s) throws
Exception {
return details;
}
- private NamedList<Object> getIndexVersion(SolrClient s) throws Exception {
+ private IndexVersionResponse getIndexVersion(SolrClient s, String coreName)
throws Exception {
- ModifiableSolrParams params = new ModifiableSolrParams();
- params.set("command", "indexversion");
- params.set("_trace", "getIndexVersion");
- var req =
- new GenericSolrRequest(
- SolrRequest.METHOD.GET, ReplicationHandler.PATH,
SolrRequestType.ADMIN, params)
- .setRequiresCollection(true);
- NamedList<Object> res = s.request(req);
- assertReplicationResponseSucceeded(res);
-
- return res;
+ final var req = new ReplicationApi.FetchIndexVersion(coreName);
Review Comment:
nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
