gerlowskija commented on code in PR #3518:
URL: https://github.com/apache/solr/pull/3518#discussion_r2330162812
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -364,8 +370,13 @@ private void fetchFileList(long gen) throws IOException {
params.set(COMMAND, CMD_GET_FILE_LIST);
params.set(GENERATION, String.valueOf(gen));
params.set(CommonParams.WT, JAVABIN);
- params.set(CommonParams.QT, ReplicationHandler.PATH);
- QueryRequest req = new QueryRequest(params);
+ var req =
Review Comment:
ditto, re: held off for now until we get a fix for
[SOLR-17549](https://issues.apache.org/jira/browse/SOLR-17549)
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -2042,10 +2057,14 @@ NamedList<Object> getDetails() throws IOException,
SolrServerException {
ModifiableSolrParams params = new ModifiableSolrParams();
params.set(COMMAND, CMD_DETAILS);
params.set("follower", false);
- params.set(CommonParams.QT, ReplicationHandler.PATH);
- QueryRequest request = new QueryRequest(params);
- // TODO use shardhandler
+ var request =
+ new GenericSolrRequest(
+ SolrRequest.METHOD.GET,
+ ReplicationHandler.PATH,
+ SolrRequest.SolrRequestType.ADMIN,
+ params)
+ .setRequiresCollection(true);
Review Comment:
Refactored for DRY
##########
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##########
@@ -220,9 +222,10 @@ private NamedList<Object> getIndexVersion(SolrClient s)
throws Exception {
ModifiableSolrParams params = new ModifiableSolrParams();
params.set("command", "indexversion");
params.set("_trace", "getIndexVersion");
- params.set("qt", ReplicationHandler.PATH);
- QueryRequest req = new QueryRequest(params);
-
+ var req =
Review Comment:
[0] I *did* switch to FetchIndexVersion here, since there's code explicitly
checking the status code at each call site.
##########
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##########
@@ -234,8 +237,9 @@ private void reloadCore(JettySolrRunner jettySolrRunner,
String core) throws Exc
ModifiableSolrParams params = new ModifiableSolrParams();
params.set("action", "reload");
params.set("core", core);
- params.set("qt", "/admin/cores");
- QueryRequest req = new QueryRequest(params);
+ var req =
Review Comment:
Tried switching to CoresApi.ReloadCore, but it looks like there's a bug in
that implementation. I've filed a ticket to follow up outside of this PR:
https://issues.apache.org/jira/browse/SOLR-17907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
