bjacobowitz opened a new pull request, #3636: URL: https://github.com/apache/solr/pull/3636
https://issues.apache.org/jira/browse/SOLR-17806 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Migrate AuthenticationPlugin metrics to OTEL # Solution Changes include: - Rename all metrics to `solr_core_authentication_plugin_<original_name_snake_case>` - Add the ability for `RTimer` to report nanosecond precision, using a new constructor which takes a `TimeUnit` (the default constructor, pre-existing, preserves the existing behavior of `RTimer` for existing users) - This was necessary to support auth timing metrics, which are measured in nanoseconds and would otherwise be truncated down to zero - This problem manifested in tests which verify that `solr_core_authentication_plugin_total_time` was non-zero (which were using the non-zero value as proof that the metric was being collected). - Add the ability for `SolrMetricTestUtils` to get histogram data points # Tests - Adjusted tests so they pass, except for: - `org.apache.solr.cloud.BasicDistributedZkTest.test (:solr:core)` - `org.apache.solr.core.TestLazyCores.testCachingLimit (:solr:core)` - `org.apache.solr.metrics.JvmMetricsTest.testSetupJvmMetrics (:solr:core)` I've been told those are existing failures. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
