bjacobowitz commented on code in PR #3636:
URL: https://github.com/apache/solr/pull/3636#discussion_r2337340805
##########
solr/core/src/java/org/apache/solr/util/RTimer.java:
##########
@@ -44,6 +45,11 @@ protected interface TimerImpl {
private static class NanoTimeTimerImpl implements TimerImpl {
private long start;
+ private final TimeUnit timeUnit;
Review Comment:
Moved.
##########
solr/core/src/java/org/apache/solr/security/MultiAuthPlugin.java:
##########
@@ -204,6 +204,7 @@ public void initializeMetrics(
// TODO SOLR-17458: Add Otel
plugin.initializeMetrics(parentContext, Attributes.empty(), scope);
Review Comment:
Added `plugin_name` as a label in the parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
