mlbiscoc commented on code in PR #3671:
URL: https://github.com/apache/solr/pull/3671#discussion_r2372898024
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -874,9 +874,7 @@ private void loadInternal() {
String cacheName = e.getKey();
c.initializeMetrics(
solrMetricsContext,
- Attributes.builder()
- .put(AttributeKey.stringKey("cache_name"), "nodeLevelCache/" +
cacheName)
- .build(),
+ Attributes.builder().put(NAME_ATTR, "nodeLevelCache/" +
cacheName).build(),
Review Comment:
Embedding it in the metric name is hacking actually... So instead I
overloaded the initializeMetrics call in CaffeineCache and set a boolean to
create the prefix of the metric name if it is node level or not. The output
looks much cleaner and tests pass for `TestThinCache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
