dsmiley commented on PR #3671: URL: https://github.com/apache/solr/pull/3671#issuecomment-3334659055
We had a nice discussion today 1:1: * the CaffeineCache should not create the metric name. The caller knows the name to use; it should pass it in * the metric name should reflect the subsystem/category of Solr where it lives. Like "solr_searcher_cache" or "solr_node_cache". I suggested maybe the cache's name should be part of the metric name, i.e. "solr_searcher_filterCache. I suggested this because the cardinality isn't highly variable and it's pretty small. And I don't imagine someone would do aggregations across all caches. But as I think about this, there's also a consistency factor, like say with request handlers. Caches and request handlers are fairly similar in this way. So if a request handler's name is *not* part of the metric name, then a cache name should probably *not* be part of the metric name either. At least it's debatable and I don't have a strong opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
