mlbiscoc commented on code in PR #3682:
URL: https://github.com/apache/solr/pull/3682#discussion_r2379611324
##########
solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java:
##########
@@ -179,127 +174,8 @@ private SolrIndexWriter(
log.warn("Invalid 'majorMergeDocs' argument, using default 512k", e);
}
}
- Boolean Totals = config.metricsInfo.initArgs.getBooleanArg("merge");
- Boolean Details =
config.metricsInfo.initArgs.getBooleanArg("mergeDetails");
- if (Details != null) {
- mergeDetails = Details;
- } else {
- mergeDetails = false;
- }
- if (Totals != null) {
- mergeTotals = Totals;
- } else {
- mergeTotals = false;
- }
- String coreName = core.getCoreDescriptor().getName();
- var baseAttributesBuilder =
- Attributes.builder()
- .put(CATEGORY_ATTR, SolrInfoBean.Category.INDEX.toString())
- .put(CORE_ATTR, coreName);
- if (core.getCoreContainer().isZooKeeperAware()) {
- String collectionName = core.getCoreDescriptor().getCollectionName();
- baseAttributesBuilder
- .put(COLLECTION_ATTR, collectionName)
- .put(SHARD_ATTR,
core.getCoreDescriptor().getCloudDescriptor().getShardId())
- .put(REPLICA_ATTR, Utils.parseMetricsReplicaName(collectionName,
coreName));
- }
- var baseAttributes = baseAttributesBuilder.build();
- if (mergeDetails) {
- mergeTotals = true; // override
- majorMergedDocs =
- new AttributedLongCounter(
- solrMetricsContext.longCounter(
- "solr_indexwriter_major_merged_docs",
- "Number of documents merged while merging segments above
the majorMergeDocs threshold ("
- + majorMergeDocs
- + ")"),
- baseAttributes);
- majorDeletedDocs =
- new AttributedLongCounter(
- solrMetricsContext.longCounter(
- "solr_indexwriter_major_deleted_docs",
- "Number of deleted documents that were expunged while
merging segments above the majorMergeDocs threshold ("
Review Comment:
I liked many of these descriptions @cugarte had added in. It gave info like
the threshold of major/minor. Can we keep these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
