dsmiley commented on code in PR #3699:
URL: https://github.com/apache/solr/pull/3699#discussion_r2380323844
##########
solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java:
##########
Review Comment:
please revert your changes here; I'd like this PR to be focused
##########
solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java:
##########
@@ -155,24 +151,19 @@ public void after() {}
public void testDiscovery() throws Exception {
setMeUp();
- // name, isLazy, loadOnStartup
- addCoreWithProps("core1", makeCoreProperties("core1", false, true,
"dataDir=core1"));
- addCoreWithProps("core2", makeCoreProperties("core2", false, false,
"dataDir=core2"));
-
- // I suspect what we're adding in here is a "configset" rather than a
schema or solrconfig.
- //
- addCoreWithProps("lazy1", makeCoreProperties("lazy1", true, false,
"dataDir=lazy1"));
+ // name, loadOnStartup
+ addCoreWithProps("core1", makeCoreProperties("core1", true,
"dataDir=core1"));
+ addCoreWithProps("core2", makeCoreProperties("core2", false,
"dataDir=core2"));
CoreContainer cc = init();
try {
TestLazyCores.checkLoadedCores(cc, "core1");
- TestLazyCores.checkCoresNotLoaded(cc, "lazy1", "core2");
+ TestLazyCores.checkCoresNotLoaded(cc, "core2");
- // force loading of core2 and lazy1 by getting them from the
CoreContainer
+ // force loading of core2 by getting them from the CoreContainer
Review Comment:
```suggestion
// force loading of core2 by getting it from the CoreContainer
```
##########
solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java:
##########
Review Comment:
This comment block should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
