dsmiley commented on code in PR #3699:
URL: https://github.com/apache/solr/pull/3699#discussion_r2380352652
##########
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##########
@@ -95,6 +90,7 @@ protected void close() {
// It might be possible for one of the cores to move from one list to
another while we're
// closing them. So loop through the lists until they're all empty. In
particular, the core
+ // NOCOMMIT I think i need help on determing what to do here.
Review Comment:
I suggest leaving this as-is in this PR. I might change my mind if I dig
into this more and want to change the abstractions in this PR... but I am not
planning on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
