igiguere commented on code in PR #3991:
URL: https://github.com/apache/solr/pull/3991#discussion_r2733661191
##########
solr/core/src/java/org/apache/solr/handler/admin/proxy/AdminHandlersProxy.java:
##########
@@ -120,36 +110,54 @@ private static void handleNamedListFormat(
}
}
if (log.isDebugEnabled()) {
- log.debug("Fetched response from {} nodes: {}", responses.size(),
responses.keySet());
+ log.debug(
+ "Fetched response from {} nodes: {}", responseFutures.size(),
responseFutures.keySet());
}
}
+ public static AdminHandlersProxy create(
+ CoreContainer coreContainer, SolrQueryRequest req, SolrQueryResponse
rsp) {
+ final var wtValue = req.getParams().get(WT);
+ if ("prometheus".equals(wtValue) || "openmetrics".equals(wtValue)) {
+ return new PrometheusRequestProxy(coreContainer, req, rsp);
+ }
+
+ return new NormalV1RequestProxy(coreContainer, req, rsp);
+ }
+
+ public static SolrRequest<?> createGenericRequest(String apiPath, SolrParams
params) {
Review Comment:
Could be abstract. The V2 support will need to create at least a
GenericV2SolrRequest, so leave creation of GenericSolrRequest to the "normal
v1" implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
