igiguere commented on code in PR #3991:
URL: https://github.com/apache/solr/pull/3991#discussion_r2733623344
##########
solr/core/src/java/org/apache/solr/handler/admin/proxy/AdminHandlersProxy.java:
##########
@@ -49,65 +49,55 @@
* Static methods to proxy calls to an Admin (GET) API to other nodes in the
cluster and return a
* combined response
*/
-public class AdminHandlersProxy {
+public abstract class AdminHandlersProxy {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- private static final String PARAM_NODES = "nodes";
- private static final String PARAM_NODE = "node";
+ protected static final String PARAM_NODES = "nodes";
+ // TODO Move to NormalV1RequestProxy if not used elsewhere when finished
Review Comment:
Actually, the "node" param is only used by the Metrics API, so it would move
to PrometheusRequestProxy.
"nodes", plural, is anything except metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
