HoustonPutman commented on code in PR #4069:
URL: https://github.com/apache/solr/pull/4069#discussion_r2744329474
##########
solr/core/src/java/org/apache/solr/cloud/ShardTerms.java:
##########
@@ -124,6 +124,28 @@ private boolean skipIncreaseTermOf(String key, Set<String>
replicasNeedingRecove
return replicasNeedingRecovery.contains(key);
}
+ public ShardTerms setHighestTerms(Set<String> highestTermKeys) {
Review Comment:
So this ultimately doesn't happen from the leader, and the leaders term is
not guaranteed to be increased. If we see in our new test class, leader
election can be triggered because of this new API.
I think the easiest thing to do here is insist that the collection is in a
read-only state when this API is called. I'm not sure how I'll do that, but it
will definitely guard against any issues with missing updates or anything like
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
