dsmiley commented on code in PR #4069:
URL: https://github.com/apache/solr/pull/4069#discussion_r2726273126
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ZkCoreNodeProps.java:
##########
@@ -47,6 +47,10 @@ public String getCoreName() {
return nodeProps.getStr(ReplicaStateProps.CORE_NAME);
}
+ public String getCoreNodeName() {
Review Comment:
even a little example of what this is/means would be helpful
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -1047,8 +1047,7 @@ public static String getShardLeadersElectPath(String
collection, String shardId)
+ (shardId != null ? ("/" + shardId + "/" + ELECTION_NODE) : "");
}
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection, String shardId, String thisCoreNodeName) {
+ public List<Replica> getReplicaProps(String collection, String shardId,
String thisCoreNodeName) {
Review Comment:
Does the name still make sense, vs `getReplica`?
##########
solr/core/src/test-files/log4j2.xml:
##########
@@ -22,7 +22,7 @@
<PatternLayout>
<Pattern>
%maxLen{%-4r %-5p (%t) [%notEmpty{n:%X{node_name}}%notEmpty{
c:%X{collection}}%notEmpty{ s:%X{shard}}%notEmpty{ r:%X{replica}}%notEmpty{
x:%X{core}}%notEmpty{ t:%X{trace_id}}] %c{1.} %m%notEmpty{
- =>%ex{short}}}{10240}%n
+ =>%ex}}{10240}%n
Review Comment:
Coincidentally, I have this same change in my working tree, and have yet to
file a PR to do this everywhere.
##########
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##########
@@ -546,7 +546,7 @@ protected void doDistribDeleteByQuery(
Replica leaderReplica =
zkController.getZkStateReader().getLeaderRetry(collection,
myShardId);
// DBQ forwarded to NRT and TLOG replicas
- List<ZkCoreNodeProps> replicaProps =
Review Comment:
it's a small thing but it's nice to see this little improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
